Update schema#2226
Merged
FabianKramm merged 4 commits intodevspace-sh:mainfrom Aug 18, 2022
Merged
Conversation
… Also changed map to interface
bagulm123
force-pushed
the
update-schema
branch
from
c4d6beb to
ab68e45
Compare
bagulm123
force-pushed
the
update-schema
branch
from
46b2b41 to
9fdb853
Compare
…d issue in pipelines, vars, commands to support multiple values
FabianKramm
approved these changes
Aug 18, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@mahendrabagul thanks for the PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made dockerfile non-mandatory, deleted generate.go as per suggestion, also changed map to interface
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2177
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...will now not make dockerfile as a mandatory flag and have some changes to reflect proper schema
What else do we need to know?