fix: supply helm registry for oci login#2242
Merged
FabianKramm merged 2 commits intodevspace-sh:mainfrom Aug 25, 2022
hendrikheil:fix/helm-registry-login-missing-target-registry
Merged
fix: supply helm registry for oci login#2242FabianKramm merged 2 commits intodevspace-sh:mainfrom hendrikheil:fix/helm-registry-login-missing-target-registry
FabianKramm merged 2 commits intodevspace-sh:mainfrom
hendrikheil:fix/helm-registry-login-missing-target-registry
Conversation
FabianKramm
approved these changes
Aug 25, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@ciidyr thanks for the PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Fixes v6.0.0-beta.0 issue where helm registry login for OCI charts did not supply target registry.
Please provide a short message that should be published in the DevSpace release notes
Fixed missing
registryargument forhelm registry loginWhat else do we need to know?
I'm not a Go developer, so have mercy.