Skip to content

Clear dependencies cache on context change #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabianKramm merged 1 commit into from
Dec 2, 2019
Merged

Clear dependencies cache on context change #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cmd/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ func (cmd *DeployCmd) Run(cobraCmd *cobra.Command, args []string) error {
return err
}

// Clear the dependencies & deployments cache if necessary
clearCache(generatedConfig, client)

// Deprecated: Fill DEVSPACE_DOMAIN vars
err = fillDevSpaceDomainVars(client, generatedConfig)
if err != nil {
Expand Down Expand Up @@ -260,3 +263,12 @@ func fillDevSpaceDomainVars(client kubectl.Client, generatedConfig *generated.Co

return nil
}

func clearCache(generatedConfig *generated.Config, client kubectl.Client) {
if generatedConfig.GetActive().LastContext != nil {
if (generatedConfig.GetActive().LastContext.Context != "" && generatedConfig.GetActive().LastContext.Context != client.CurrentContext()) || (generatedConfig.GetActive().LastContext.Namespace != "" && generatedConfig.GetActive().LastContext.Namespace != client.Namespace()) {
generatedConfig.GetActive().Deployments = map[string]*generated.DeploymentCache{}
generatedConfig.GetActive().Dependencies = map[string]string{}
}
}
}
3 changes: 3 additions & 0 deletions cmd/dev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,9 @@ func (cmd *DevCmd) Run(cobraCmd *cobra.Command, args []string) error {
return err
}

// Clear the dependencies & deployments cache if necessary
clearCache(generatedConfig, client)

// Deprecated: Fill DEVSPACE_DOMAIN vars
err = fillDevSpaceDomainVars(client, generatedConfig)
if err != nil {
Expand Down