refactor: splitting github actions plugin into different ones accordi… #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Key Points
Description
githubactionsplugin is split into 3 plugins (by programming language):githubactions-golanggithubactions-pythongithubactions-nodejsThere will be duplicated code, but it's OK since they are three different plugins now. They may grow into different directions (at the moment, the Golang one already differs from the other two since it may also create repo secrets)
Creating GitHub client is updated to use
pkg/util/github.For Golang, the pipeline is split into two (one PR builder, one main builder; the reason being some step is only required in the PR builder.)
Improved secrets handling during reinstall/uninstall for Golang.