fix: stop e2e test when encounter errors

[xavier-hou]

Signed-off-by: hxcGit houxc_mail@163.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

• I have read through the CONTRIBUTING.md documentation.
• My code has the necessary comments and documentation (if needed).
• I have added relevant tests

Description

fix e2e script: terminate e2e test when encounter errors

Related Issues

#873

New Behavior (screenshots if needed)

[iyear]

Well Done! 🚀

[xavier-hou]

e2e test log

{22-07-21 9:40}hxc-macbook-air:devstream@local-e2e✗✗✗✗✗✗ hxc% bash hack/e2e/e2e-run.sh           
[dtm e2e test script] Create k8s cluster by kind!
Deleting cluster "devstream-e2e" ...
Got OS type: darwin and CPU arch: arm64
Requires having Docker installed
All tools save in hack/e2e/../../hack/e2e/../../testbin directory
kind already downloaded
kubectl already downloaded
/Users/hxc/WorkFolder/regular/public/devstream
v1.22.0: Pulling from kindest/node
Digest: sha256:b8bda84bb3a190e6e028b1760d277454a72267a5454b57db34437c34a588d047
Status: Image is up to date for kindest/node:v1.22.0
docker.io/kindest/node:v1.22.0
Creating cluster "devstream-e2e" ...
 ✓ Ensuring node image (kindest/node:v1.22.0) 🖼 
 ✓ Preparing nodes 📦  
 ✓ Writing configuration 📜 
 ✓ Starting control-plane 🕹️ 
 ✓ Installing CNI 🔌 
 ✓ Installing StorageClass 💾 
Set kubectl context to "kind-devstream-e2e"
You can now use your cluster with:

kubectl cluster-info --context kind-devstream-e2e

Have a nice day! 👋
[dtm e2e test script] Start dtm e2e test locally!
2022-07-21 09:40:46 ℹ [INFO]  Apply started.
2022-07-21 09:40:46 ℹ [INFO]  Got Backend from config: local
2022-07-21 09:40:46 ℹ [INFO]  Using dir <.devstream> to store plugins.
2022-07-21 09:40:47 ℹ [INFO]  Using local backend. State file: devstream.state.
2022-07-21 09:40:47 ℹ [INFO]  Tool (github-repo-scaffolding-golang/default) found in config but doesn't exist in the state, will be created.
2022-07-21 09:40:47 ℹ [INFO]  Tool (argocd/default) found in config but doesn't exist in the state, will be created.
2022-07-21 09:40:47 ℹ [INFO]  Tool (githubactions-golang/default) found in config but doesn't exist in the state, will be created.
2022-07-21 09:40:47 ℹ [INFO]  Tool (argocdapp/default) found in config but doesn't exist in the state, will be created.
2022-07-21 09:40:47 ℹ [INFO]  Start executing the plan.
2022-07-21 09:40:47 ℹ [INFO]  Changes count: 4.
2022-07-21 09:40:47 ℹ [INFO]  -------------------- [  Processing progress: 1/4.  ] --------------------
2022-07-21 09:40:47 ℹ [INFO]  Processing: (github-repo-scaffolding-golang/default) -> Create ...
2022-07-21 09:40:50 ℹ [INFO]  The repo dtm-e2e-test-golang has been created.
2022-07-21 09:41:02 ✔ [SUCCESS]  Tool (github-repo-scaffolding-golang/default) Create done.
2022-07-21 09:41:02 ℹ [INFO]  -------------------- [  Processing progress: 2/4.  ] --------------------
2022-07-21 09:41:02 ℹ [INFO]  Processing: (argocd/default) -> Create ...
2022-07-21 09:41:03 ℹ [INFO]  Creating or updating helm chart ...
2022/07/21 09:41:06 creating 1 resource(s)
2022/07/21 09:41:06 creating 1 resource(s)
2022/07/21 09:41:07 creating 1 resource(s)
2022/07/21 09:41:07 creating 1 resource(s)
2022/07/21 09:41:07 Clearing discovery cache
2022/07/21 09:41:07 beginning wait for 4 resources with timeout of 1m0s
2022/07/21 09:41:11 creating 43 resource(s)
2022/07/21 09:41:11 beginning wait for 43 resources with timeout of 10m0s
2022/07/21 09:41:12 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:14 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:16 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:18 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:20 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:22 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:24 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:26 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:28 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:30 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:32 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:34 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:36 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:38 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:40 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:42 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:44 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:46 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:48 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:50 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:52 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:54 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:56 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:41:58 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:42:00 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:42:02 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:42:04 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:42:06 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:42:08 Deployment is not ready: argocd-e2e-test/argocd-applicationset-controller. 0 out of 1 expected pods are ready
2022/07/21 09:42:10 Deployment is not ready: argocd-e2e-test/argocd-repo-server. 0 out of 1 expected pods are ready
2022/07/21 09:42:12 Deployment is not ready: argocd-e2e-test/argocd-repo-server. 0 out of 1 expected pods are ready
2022/07/21 09:42:14 Deployment is not ready: argocd-e2e-test/argocd-repo-server. 0 out of 1 expected pods are ready
2022/07/21 09:42:16 Deployment is not ready: argocd-e2e-test/argocd-repo-server. 0 out of 1 expected pods are ready
2022/07/21 09:42:18 Deployment is not ready: argocd-e2e-test/argocd-repo-server. 0 out of 1 expected pods are ready
2022/07/21 09:42:20 Deployment is not ready: argocd-e2e-test/argocd-repo-server. 0 out of 1 expected pods are ready
2022/07/21 09:42:22 Deployment is not ready: argocd-e2e-test/argocd-repo-server. 0 out of 1 expected pods are ready
2022/07/21 09:42:24 Deployment is not ready: argocd-e2e-test/argocd-repo-server. 0 out of 1 expected pods are ready
2022/07/21 09:42:27 release installed successfully: argocd/argo-cd-4.9.16
2022-07-21 09:42:27 ✔ [SUCCESS]  Tool (argocd/default) Create done.
2022-07-21 09:42:27 ℹ [INFO]  -------------------- [  Processing progress: 3/4.  ] --------------------
2022-07-21 09:42:27 ℹ [INFO]  Processing: (githubactions-golang/default) -> Create ...
2022-07-21 09:42:29 ℹ [INFO]  Creating GitHub Actions workflow pr-builder.yml ...
2022-07-21 09:42:29 ✔ [SUCCESS]  Github Actions workflow pr-builder.yml created.
2022-07-21 09:42:30 ℹ [INFO]  Creating GitHub Actions workflow main-builder.yml ...
2022-07-21 09:42:30 ✔ [SUCCESS]  Github Actions workflow main-builder.yml created.
2022-07-21 09:42:30 ✔ [SUCCESS]  Tool (githubactions-golang/default) Create done.
2022-07-21 09:42:30 ℹ [INFO]  -------------------- [  Processing progress: 4/4.  ] --------------------
2022-07-21 09:42:30 ℹ [INFO]  Processing: (argocdapp/default) -> Create ...
2022-07-21 09:42:31 ℹ [INFO]  All opts &map[app:map[name:dtm-e2e-test-golang namespace:argocd-e2e-test] destination:map[namespace:default server:https://kubernetes.default.svc] source:map[path:helm/dtm-e2e-test-golang repoURL:https://github.com/hxcGit/dtm-e2e-test-golang.git valuefile:values.yaml]]
2022-07-21 09:42:31 ℹ [INFO]  application.argoproj.io/dtm-e2e-test-golang created
2022-07-21 09:42:31 ✔ [SUCCESS]  Tool (argocdapp/default) Create done.
2022-07-21 09:42:31 ℹ [INFO]  -------------------- [  Processing done.  ] --------------------
2022-07-21 09:42:31 ✔ [SUCCESS]  All plugins applied successfully.
2022-07-21 09:42:31 ✔ [SUCCESS]  Apply finished.
[dtm e2e test script] Start check pod status!
pod not ready yet...
pod not ready yet...
[dtm e2e test script] Pod is ready!
2022-07-21 09:42:51 ℹ [INFO]  Verify started.
2022-07-21 09:42:51 ℹ [INFO]  Got Backend from config: local
2022-07-21 09:42:51 ℹ [INFO]  Using dir <.devstream> to store plugins.
2022-07-21 09:42:52 ℹ [INFO]  Using local backend. State file: devstream.state.
2022-07-21 09:42:54 ✔ [SUCCESS]  Verify succeeded.
2022-07-21 09:42:54 ℹ [INFO]  Delete started.
2022-07-21 09:42:54 ℹ [INFO]  Got Backend from config: local
2022-07-21 09:42:54 ℹ [INFO]  Using dir <.devstream> to store plugins.
2022-07-21 09:42:54 ℹ [INFO]  Using local backend. State file: devstream.state.
2022-07-21 09:42:54 ℹ [INFO]  Tool (githubactions-golang/default) will be deleted.
2022-07-21 09:42:54 ℹ [INFO]  Tool (argocdapp/default) will be deleted.
2022-07-21 09:42:54 ℹ [INFO]  Tool (github-repo-scaffolding-golang/default) will be deleted.
2022-07-21 09:42:54 ℹ [INFO]  Tool (argocd/default) will be deleted.
2022-07-21 09:42:54 ℹ [INFO]  Start executing the plan.
2022-07-21 09:42:54 ℹ [INFO]  Changes count: 4.
2022-07-21 09:42:54 ℹ [INFO]  -------------------- [  Processing progress: 1/4.  ] --------------------
2022-07-21 09:42:54 ℹ [INFO]  Processing: (githubactions-golang/default) -> Delete ...
2022-07-21 09:42:56 ℹ [INFO]  Deleting GitHub Actions workflow pr-builder.yml ...
2022-07-21 09:42:56 ✔ [SUCCESS]  GitHub Actions workflow pr-builder.yml removed.
2022-07-21 09:42:56 ℹ [INFO]  Deleting GitHub Actions workflow main-builder.yml ...
2022-07-21 09:42:57 ✔ [SUCCESS]  GitHub Actions workflow main-builder.yml removed.
2022-07-21 09:42:57 ℹ [INFO]  Prepare to delete 'githubactions-golang_default' from States.
2022-07-21 09:42:57 ✔ [SUCCESS]  Tool (githubactions-golang/default) delete done.
2022-07-21 09:42:57 ℹ [INFO]  -------------------- [  Processing progress: 2/4.  ] --------------------
2022-07-21 09:42:57 ℹ [INFO]  Processing: (argocdapp/default) -> Delete ...
2022-07-21 09:42:57 ℹ [INFO]  All opts &map[app:map[name:dtm-e2e-test-golang namespace:argocd-e2e-test] destination:map[namespace:default server:https://kubernetes.default.svc] source:map[path:helm/dtm-e2e-test-golang repoURL:https://github.com/hxcGit/dtm-e2e-test-golang.git valuefile:values.yaml]]
2022-07-21 09:42:59 ℹ [INFO]  application.argoproj.io "dtm-e2e-test-golang" deleted
2022-07-21 09:42:59 ℹ [INFO]  Prepare to delete 'argocdapp_default' from States.
2022-07-21 09:42:59 ✔ [SUCCESS]  Tool (argocdapp/default) delete done.
2022-07-21 09:42:59 ℹ [INFO]  -------------------- [  Processing progress: 3/4.  ] --------------------
2022-07-21 09:42:59 ℹ [INFO]  Processing: (github-repo-scaffolding-golang/default) -> Delete ...
2022-07-21 09:43:00 ✔ [SUCCESS]  GitHub repo dtm-e2e-test-golang removed.
2022-07-21 09:43:00 ℹ [INFO]  Prepare to delete 'github-repo-scaffolding-golang_default' from States.
2022-07-21 09:43:00 ✔ [SUCCESS]  Tool (github-repo-scaffolding-golang/default) delete done.
2022-07-21 09:43:00 ℹ [INFO]  -------------------- [  Processing progress: 4/4.  ] --------------------
2022-07-21 09:43:00 ℹ [INFO]  Processing: (argocd/default) -> Delete ...
2022-07-21 09:43:01 ℹ [INFO]  Uninstalling argocd helm chart.
2022/07/21 09:43:01 uninstall: Deleting argocd
2022/07/21 09:43:03 Starting delete for "argocd-redis" Service
2022/07/21 09:43:03 Starting delete for "argocd-repo-server" Service
2022/07/21 09:43:03 Starting delete for "argocd-applicationset-controller" Service
2022/07/21 09:43:03 Starting delete for "argocd-server" Service
2022/07/21 09:43:03 Starting delete for "argocd-application-controller" Service
2022/07/21 09:43:03 Starting delete for "argocd-dex-server" Service
2022/07/21 09:43:03 Starting delete for "argocd-application-controller" StatefulSet
2022/07/21 09:43:03 Starting delete for "argocd-redis" Deployment
2022/07/21 09:43:03 Starting delete for "argocd-repo-server" Deployment
2022/07/21 09:43:03 Starting delete for "argocd-notifications-controller" Deployment
2022/07/21 09:43:03 Starting delete for "argocd-server" Deployment
2022/07/21 09:43:03 Starting delete for "argocd-applicationset-controller" Deployment
2022/07/21 09:43:03 Starting delete for "argocd-dex-server" Deployment
2022/07/21 09:43:04 Starting delete for "argocd-application-controller" RoleBinding
2022/07/21 09:43:04 Starting delete for "argocd-applicationset-controller" RoleBinding
2022/07/21 09:43:04 Starting delete for "argocd-dex-server" RoleBinding
2022/07/21 09:43:04 Starting delete for "argocd-repo-server" RoleBinding
2022/07/21 09:43:04 Starting delete for "argocd-notifications-controller" RoleBinding
2022/07/21 09:43:04 Starting delete for "argocd-server" RoleBinding
2022/07/21 09:43:04 Starting delete for "argocd-application-controller" Role
2022/07/21 09:43:04 Starting delete for "argocd-applicationset-controller" Role
2022/07/21 09:43:04 Starting delete for "argocd-dex-server" Role
2022/07/21 09:43:04 Starting delete for "argocd-notifications-controller" Role
2022/07/21 09:43:04 Starting delete for "argocd-repo-server" Role
2022/07/21 09:43:04 Starting delete for "argocd-server" Role
2022/07/21 09:43:04 Starting delete for "argocd-server" ClusterRoleBinding
2022/07/21 09:43:04 Starting delete for "argocd-application-controller" ClusterRoleBinding
2022/07/21 09:43:04 Starting delete for "argocd-server" ClusterRole
2022/07/21 09:43:04 Starting delete for "argocd-application-controller" ClusterRole
2022/07/21 09:43:04 Starting delete for "argocd-gpg-keys-cm" ConfigMap
2022/07/21 09:43:04 Starting delete for "argocd-cm" ConfigMap
2022/07/21 09:43:04 Starting delete for "argocd-notifications-controller-cm" ConfigMap
2022/07/21 09:43:04 Starting delete for "argocd-ssh-known-hosts-cm" ConfigMap
2022/07/21 09:43:04 Starting delete for "argocd-rbac-cm" ConfigMap
2022/07/21 09:43:04 Starting delete for "argocd-tls-certs-cm" ConfigMap
2022/07/21 09:43:04 Starting delete for "argocd-notifications-controller-secret" Secret
2022/07/21 09:43:04 Starting delete for "argocd-secret" Secret
2022/07/21 09:43:04 Starting delete for "argocd-notifications-controller" ServiceAccount
2022/07/21 09:43:04 Starting delete for "argocd-application-controller" ServiceAccount
2022/07/21 09:43:04 Starting delete for "argocd-applicationset-controller" ServiceAccount
2022/07/21 09:43:04 Starting delete for "argocd-dex-server" ServiceAccount
2022/07/21 09:43:04 Starting delete for "argocd-repo-server" ServiceAccount
2022/07/21 09:43:04 Starting delete for "argocd-server" ServiceAccount
2022/07/21 09:43:04 purge requested for argocd
2022/07/21 09:43:05 release uninstalled, response: &{0x14000220000 }
2022-07-21 09:43:05 ℹ [INFO]  Prepare to delete 'argocd_default' from States.
2022-07-21 09:43:05 ✔ [SUCCESS]  Tool (argocd/default) delete done.
2022-07-21 09:43:05 ℹ [INFO]  -------------------- [  Processing done.  ] --------------------
2022-07-21 09:43:05 ✔ [SUCCESS]  All plugins deleted successfully.
2022-07-21 09:43:05 ✔ [SUCCESS]  Delete finished.
/Users/hxc/WorkFolder/regular/public/devstream
[dtm e2e test script] Start to clean test environment and configuration files!
[dtm e2e test script] Remove k8s cluster!
Deleting cluster "devstream-e2e" ...
[dtm e2e test script] Remove yaml files!
[dtm e2e test script] E2E test success!

Many thanks for @iyear's help.

@IronCore864 @iyear PTAL

[iyear]

The commit msg seems to have a redundant Add.

[xavier-hou]

The commit msg seems to have a redundant Add.

Done.