Skip to content

fix: stop e2e test when encounter errors #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-hutao merged 2 commits into from
Jul 21, 2022
Merged

fix: stop e2e test when encounter errors #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41321f3
fix: stop e2e test when encounter errors
xavier-hou Jul 20, 2022
f95db5b
fix: add quotes to avoid yaml marshaling error
xavier-hou Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions hack/e2e/e2e-run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,28 @@ function run_test() {

echo "[dtm e2e test script] Start dtm e2e test locally!"
./dtm apply -f ${CONFIG_FILENAME} -y
if [ $? -ne 0 ]; then
echo "[dtm e2e test script] Execute dtm apply failed!"
clean_up
exit 1
fi

check_status

./dtm verify -f ${CONFIG_FILENAME}
if [ $? -ne 0 ]; then
echo "[dtm e2e test script] Execute dtm verify failed!"
clean_up
exit 1
fi

./dtm delete -f ${CONFIG_FILENAME} -y
if [ $? -ne 0 ]; then
echo "[dtm e2e test script] Execute dtm delete failed!"
clean_up
exit 1
fi

cd -
}

Expand Down
2 changes: 1 addition & 1 deletion test/e2e/yaml/e2e-test-local.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ tools:
owner: [[ githubUsername ]]
repo: [[ repoName ]]
branch: [[ defaultBranch ]]
image_repo: [[ dockerRegistryUserName ]]/[[ repoName ]]
image_repo: "[[ dockerRegistryUserName ]]/[[ repoName ]]"
- name: githubactions-golang
instanceID: default
dependsOn: ["github-repo-scaffolding-golang.default"]
Expand Down