feat: pkg-util-github-pullrequest enhancement #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@daniel-hutao I try to make a ut by using |
jxs1211
force-pushed
the
feat-pkg-util-github-pullrequest
branch
from
3bbaa55 to
2667d86
Compare
steinliber
reviewed
Jul 27, 2022
steinliber
left a comment
steinliber
left a comment
There was a problem hiding this comment.
I think this test is great. only one concern, should we have exposed variable in test, what do you guys think @devstream-io/reviewer
xavier-hou
reviewed
Jul 27, 2022
iyear
reviewed
Jul 27, 2022
Member
|
@jxs1211 Hi，if you have time please check whether the above comments need to be adjusted and resolve the conflict. |
jxs1211
force-pushed
the
feat-pkg-util-github-pullrequest
branch
from
2667d86 to
300c4ea
Compare
Author
steinliber
approved these changes
Aug 2, 2022
Member
|
@jxs1211 Please check the CI error, I will merge it in as soon as possible after solving. |
Signed-off-by: xian-jie.shen <327411586@qq.com>
jxs1211
force-pushed
the
feat-pkg-util-github-pullrequest
branch
from
300c4ea to
22d1a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xian-jie.shen 327411586@qq.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
add ut for pullrequest
Related Issues
see #833 for the details
New Behavior (screenshots if needed)