Skip to content

Conversation

@jxs1211
Copy link

@jxs1211 jxs1211 commented Jul 26, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

add ut for secrets

Related Issues

see #833 for the details

New Behavior (screenshots if needed)

[going@dev github]$ go tool cover -func=coverage.out
...
github.com/devstream-io/devstream/pkg/util/github/secrets.go:14:                AddRepoSecret                           92.3%
github.com/devstream-io/devstream/pkg/util/github/secrets.go:44:                encryptSecretWithPublicKey              84.6%
github.com/devstream-io/devstream/pkg/util/github/secrets.go:76:                DeleteRepoSecret                        90.0%
github.com/devstream-io/devstream/pkg/util/github/secrets.go:95:                RepoSecretExists                        90.0%
...
total:                                                                          (statements)                            36.8%

@jxs1211 jxs1211 requested a review from a team as a code owner July 26, 2022 11:58
@jxs1211 jxs1211 force-pushed the feat-pkg-util-github-secrets branch from 869851e to fa6741d Compare July 27, 2022 04:52
@xavier-hou
Copy link
Member

@jxs1211 Many thanks to your test! Please merge the redundant git commits.

@jxs1211
Copy link
Author

jxs1211 commented Jul 27, 2022

@jxs1211 Many thanks to your test! Please merge the redundant git commits.

@HXCGIT
the previous 2 prs(#905, https://github.com/devstream-io/devstream/pull/909/commits) haven't been merged yet, this pr is created by checkout the 2 previous pr, I will try to handle the redundant commits on this pr.

Signed-off-by: xian-jie.shen <327411586@qq.com>
@jxs1211 jxs1211 force-pushed the feat-pkg-util-github-secrets branch from fa6741d to cef9d6c Compare July 27, 2022 10:57
@xavier-hou
Copy link
Member

@jxs1211 I think each individual PR should be checked out from main branch. This allows for independent modification and merging of PR~

@xavier-hou xavier-hou merged commit b67bb33 into devstream-io:main Jul 28, 2022
@jxs1211
Copy link
Author

jxs1211 commented Aug 2, 2022

@jxs1211 I think each individual PR should be checked out from main branch. This allows for independent modification and merging of PR~

yes, I will keep it in my mind next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants