Skip to content

Allow Stringable variables in if statements #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 14, 2025
Merged

Allow Stringable variables in if statements #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f78192
allow \Stringable in Runtime::ifVar
passchn Oct 14, 2025
650de0c
add test for stringable value
passchn Oct 14, 2025
b2e032d
static + code style
passchn Oct 14, 2025
bd91594
revert github codestyle changes
passchn Oct 14, 2025
b4212ea
fix cs
passchn Oct 14, 2025
992c730
Fix CS
theodorejb Oct 14, 2025
be9cb02
Simplify ifvar tests
theodorejb Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/Runtime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,19 @@ public static function lo(array $v): string
/**
* For {{#if}} and {{#unless}}.
*
* @param array<array<mixed>|string|int>|string|int|float|bool|null $v value to be tested
* @param array<array<mixed>|string|int>|string|\Stringable|int|float|bool|null $v value to be tested
* @param bool $zero include zero as true
*
* @return bool Return true when the value is not null nor false.
*/
public static function ifvar(mixed $v, bool $zero): bool
public static function ifvar(mixed $v, bool $zero = false): bool
{
return $v !== null && $v !== false && ($zero || ($v !== 0 && $v !== 0.0)) && $v !== '' && (!is_array($v) || count($v) > 0);
return $v !== null
&& $v !== false
&& ($zero || ($v !== 0 && $v !== 0.0))
&& $v !== ''
&& (!$v instanceof \Stringable || (string) $v !== '')
&& (!is_array($v) || count($v) > 0);
}

/**
Expand Down
34 changes: 24 additions & 10 deletions tests/RuntimeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,19 @@ class RuntimeTest extends TestCase
{
public function testIfVar(): void
{
$this->assertFalse(Runtime::ifvar(null, false));
$this->assertFalse(Runtime::ifvar(0, false));
$this->assertFalse(Runtime::ifvar(null));
$this->assertFalse(Runtime::ifvar(0));
$this->assertTrue(Runtime::ifvar(0, true));
$this->assertFalse(Runtime::ifvar(false, false));
$this->assertTrue(Runtime::ifvar(true, false));
$this->assertTrue(Runtime::ifvar(1, false));
$this->assertFalse(Runtime::ifvar('', false));
$this->assertTrue(Runtime::ifvar('0', false));
$this->assertFalse(Runtime::ifvar([], false));
$this->assertTrue(Runtime::ifvar([''], false));
$this->assertTrue(Runtime::ifvar([0], false));
$this->assertFalse(Runtime::ifvar(false));
$this->assertTrue(Runtime::ifvar(true));
$this->assertTrue(Runtime::ifvar(1));
$this->assertFalse(Runtime::ifvar(''));
$this->assertTrue(Runtime::ifvar('0'));
$this->assertFalse(Runtime::ifvar([]));
$this->assertTrue(Runtime::ifvar(['']));
$this->assertTrue(Runtime::ifvar([0]));
$this->assertFalse(Runtime::ifvar(self::createStringable('')));
$this->assertTrue(Runtime::ifvar(self::createStringable('0')));
}

public function testIsec(): void
Expand All @@ -41,4 +43,16 @@ public function testWi(): void
$this->assertSame('{"a":"b"}', Runtime::wi($cx, ['a' => 'b'], null, ['a' => 'c'], function ($c, $i) {return json_encode($i); }));
$this->assertSame('-b=', Runtime::wi($cx, 'b', null, ['a' => 'b'], function ($c, $i) {return "-$i="; }));
}

private static function createStringable(string $value): \Stringable
{
return new class ($value) implements \Stringable {
public function __construct(private string $value) {}

public function __toString(): string
{
return $this->value;
}
};
}
}