This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Have firefox onConnect wait for newSources#2997
Merged
jasonLaster merged 1 commit intofirefox-devtools:masterfrom May 23, 2017
Merged
Have firefox onConnect wait for newSources#2997jasonLaster merged 1 commit intofirefox-devtools:masterfrom
jasonLaster merged 1 commit intofirefox-devtools:masterfrom
Conversation
This fixes a race where panel.js can report that the debugger has started, but where getSources will still return null for a source that does in fact exist. See https://bugzilla.mozilla.org/show_bug.cgi?id=1364526
Codecov Report
@@ Coverage Diff @@
## master #2997 +/- ##
==========================================
+ Coverage 63.44% 63.61% +0.17%
==========================================
Files 70 72 +2
Lines 2473 2515 +42
Branches 507 514 +7
==========================================
+ Hits 1569 1600 +31
- Misses 904 915 +11
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a race where panel.js can report that the debugger has
started, but where getSources will still return null for a source that
does in fact exist.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1364526