This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Added changes use local/sessionStorage objects in object actor#1046
Merged
Conversation
nchevobbe
approved these changes
Apr 19, 2018
Member
nchevobbe
left a comment
nchevobbe
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Mike !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes here are harmless and don't depend upon the patch from https://bugzil.la/1454103
We were sometimes missing keys on local and session storage because we were trying to iterate over these special objects using the wrong methods.
This patch along with the bugzilla patch allow us to display the storage types entries in a similar way to a map or sets entries are displayed.
Screenshots of the new storage object display in the Web Console and Debugger
Web Console (collapsed)
Web Console (expanded)
Debugger (expanded)