Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/devtools-connection/src/debugger/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -2779,8 +2779,8 @@ ObjectClient.prototype = {
},
{
before: function(packet) {
if (!["Map", "WeakMap", "Set", "WeakSet"].includes(this._grip.class)) {
throw new Error("enumEntries is only valid for Map/Set-like grips.");
if (!["Map", "WeakMap", "Set", "WeakSet", "Storage"].includes(this._grip.class)) {
throw new Error("enumEntries is only valid for Map/Set/Storage-like grips.");
}
return packet;
},
Expand Down
3 changes: 2 additions & 1 deletion packages/devtools-reps/src/object-inspector/utils/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ function nodeHasEntries(
return value.class === "Map"
|| value.class === "Set"
|| value.class === "WeakMap"
|| value.class === "WeakSet";
|| value.class === "WeakSet"
|| value.class === "Storage";
}

function nodeHasAllEntriesInPreview(item : Node) : boolean {
Expand Down
4 changes: 3 additions & 1 deletion packages/devtools-reps/src/reps/grip-map-entry.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ function supportsObject(grip, noGrip = false) {
if (noGrip === true) {
return false;
}
return (grip && grip.type === "mapEntry" && grip.preview);
return grip &&
(grip.type === "mapEntry" || grip.type === "storageEntry") &&
grip.preview;
}

function createGripMapEntry(key, value) {
Expand Down