Skip to content

Add X link and icon to header#17

Merged
abcoathup merged 3 commits intodevtoolsguild:mainfrom
kuzdogan:main
Sep 15, 2025
Merged

Add X link and icon to header#17
abcoathup merged 3 commits intodevtoolsguild:mainfrom
kuzdogan:main

Conversation

@kuzdogan
Copy link
Copy Markdown
Contributor

I think we should have an X link that is more visible. While on it I've styled it a bit

image

@abcoathup
Copy link
Copy Markdown
Contributor

Great idea @kuzdogan
When I tested the PR locally, the GitHub & X icons didn't appear (tried system/light/dark modes).
When changing the browser size to mobile, text for GitHub & X menu items wasn't shown.

@kuzdogan
Copy link
Copy Markdown
Contributor Author

I was able to reproduce it. It should be fixed now can you check again?

@abcoathup
Copy link
Copy Markdown
Contributor

@kuzdogan when resizing for mobile:

  • hamburger menu shows icons for GitHub, Twitter and home, this should either be text, or appear next to dark/light icon at top of menu.
  • | is a link to home and appears in the hamburger menu.
  • GitHub & X icons don't hide for mobile, but the dark/light mode does
{B5743CC6-63AD-4425-BDFC-B5598C32CE30}

@kuzdogan
Copy link
Copy Markdown
Contributor Author

Thanks, done

@abcoathup abcoathup merged commit 3f80264 into devtoolsguild:main Sep 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants