-
Notifications
You must be signed in to change notification settings - Fork 57
feat: Configuration Change Exception - Deployment Template #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RohitRaj011
merged 13 commits into
feature/approval-policy-exceptions
from
feat/configuration-exception
Apr 2, 2025
Merged
feat: Configuration Change Exception - Deployment Template #2585
RohitRaj011
merged 13 commits into
feature/approval-policy-exceptions
from
feat/configuration-exception
Apr 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S - Express Edit Partial UI
…abs/dashboard into feat/configuration-exception
…xpress edit inside express edit view
…handling of Express Delete flow and other optimisations
AbhishekA1509
requested changes
Mar 31, 2025
...plications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/constants.ts
Outdated
Show resolved
Hide resolved
.../DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DeploymentTemplate.tsx
Outdated
Show resolved
Hide resolved
...Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/service.ts
Outdated
Show resolved
Hide resolved
...onApps/Details/AppConfigurations/MainContent/DeploymentTemplate/deploymentTemplateReducer.ts
Show resolved
Hide resolved
...tronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DeploymentTemplateForm.tsx
Outdated
Show resolved
Hide resolved
...tronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DeploymentTemplateForm.tsx
Outdated
Show resolved
Hide resolved
...tronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DeploymentTemplateForm.tsx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,21 @@ | |||
| @mixin border($name, $color) { | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On merging need to ensure this comes in gatekeeper repo as well
AbhishekA1509
approved these changes
Apr 1, 2025
…on-labs/dashboard into feat/configuration-exception
|
7fa1464
into
feature/approval-policy-exceptions
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Configuration Change Exception
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1863
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: