Skip to content

Conversation

@ashoknayak777
Copy link
Contributor

Copied PR content from old repo and incorporated PM's feedback:
devtron-labs/devtron#5810

@ashoknayak777 ashoknayak777 requested review from a team as code owners September 26, 2024 13:42
@ashoknayak777 ashoknayak777 self-assigned this Sep 26, 2024
@ashoknayak777 ashoknayak777 added the documentation Improvements or additions to documentation label Sep 26, 2024
@ashoknayak777 ashoknayak777 requested a review from abhibhaw January 7, 2025 08:39
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments which needs to be addressed, I may not have answer for all of them at this moment, maybe we can merge this PR and tackle the queries in a separate one, considering this has been here for last 4 months

@ashoknayak777
Copy link
Contributor Author

I have left a few comments which needs to be addressed, I may not have answer for all of them at this moment, maybe we can merge this PR and tackle the queries in a separate one, considering this has been here for last 4 months

Created an issue for myself to incorporate all pending suggestions: #32

@ashoknayak777 ashoknayak777 merged commit 4a19e18 into main Jan 9, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants