Skip to content

Conversation

@ashoknayak777
Copy link
Contributor

@ashoknayak777 ashoknayak777 commented Dec 10, 2024

Sample Preview

  • Rewrote from scratch
  • Added updated images and gifs
  • Added tutorial videos for Email, Slack, Webhook notifications
  • Included RBAC

@ashoknayak777 ashoknayak777 added the documentation Improvements or additions to documentation label Dec 10, 2024
@ashoknayak777 ashoknayak777 self-assigned this Dec 10, 2024
@ashoknayak777 ashoknayak777 requested review from a team as code owners December 10, 2024 16:42
@ashoknayak777 ashoknayak777 force-pushed the revamp-notification-doc branch from f5b16a3 to 410ff62 Compare December 11, 2024 08:38
badal773
badal773 previously approved these changes Dec 12, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMTP and SES is independent, using it interchangeably is confusing for the user.

@ashoknayak777
Copy link
Contributor Author

SMTP and SES is independent, using it interchangeably is confusing for the user.

@abhibhaw, In the case of AWS, SES and SMTP are used in the same breath (snapshot attached below)
image

@bharathvaj-p bharathvaj-p requested a review from a team as a code owner May 29, 2025 03:27
@bharathvaj-p bharathvaj-p changed the title doc: Revamped Notification Doc docs: Revamped Notification Doc May 30, 2025
@bharathvaj-p bharathvaj-p self-assigned this May 30, 2025
@ashoknayak777
Copy link
Contributor Author

ashoknayak777 commented May 30, 2025

LGTM, @bharathvaj-p
@badal773, can you quickly verify the payload mentioned in this PR (MS Teams and RingCentral Payloads shared by you 6 months ago) are still valid?

@bharathvaj-p bharathvaj-p requested a review from abhibhaw June 2, 2025 07:19
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathvaj-p bharathvaj-p merged commit 67c41f2 into main Jun 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants