Skip to content

Conversation

@arunjaindev
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cluster cost module support, introduces a new "SunsetOrange" color token for charts, fixes checkbox event handling in bulk selection, and enables cursor-following tooltips.

  • Adds getAllClusterListMin service function to fetch minimal cluster data including cost module configuration
  • Introduces "SunsetOrange" color token with light and dark theme variants for chart components
  • Fixes checkbox interaction in BulkSelection by moving handler from onClick to onChange
  • Enables followCursor plugin for all tooltips

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Shared/Services/types.ts Defines AllClusterListMinItemDTO type for cluster cost module data
src/Shared/Services/common.service.ts Implements getAllClusterListMin API service function
src/Shared/Helpers.tsx Adds configurable precision to currency formatting function
src/Shared/Components/Charts/types.ts Adds "SunsetOrange" color token type
src/Shared/Components/Charts/constants.ts Defines "SunsetOrange" color palette for both themes
src/Shared/Components/BulkSelection/BulkSelection.tsx Fixes checkbox event handler placement
src/Common/Tooltip/Tooltip.tsx Enables cursor-following behavior for all tooltips
src/Common/Constants.ts Adds CLUSTER_MIN API route constant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arunjaindev arunjaindev merged commit 538ae44 into kubecon-2025 Nov 6, 2025
3 checks passed
@arunjaindev arunjaindev deleted the fix/command-bar-cluster-list branch November 6, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants