Skip to content

Conversation

@Shubham9t9
Copy link
Contributor

@Shubham9t9 Shubham9t9 commented Jan 24, 2022

Description

Updates in documentation:

  1. Added how we can see logs of devtron installer while installing devtron.
  2. Added how we can apply liveness & readiness probes by executing commands.
  3. Added pathType in ingress.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles

@arushi09-hub
Copy link
Contributor

Please write proper description & Title of the PR

@Shubham9t9 Shubham9t9 changed the title DOC: Documentation update DOC: Documentation updates Feb 15, 2022
@Shubham9t9 Shubham9t9 changed the title DOC: Documentation updates DOC: Documentation updates for devtron installation, ingess, liveness and readiness probe Feb 15, 2022
- host: example1.com
paths:
- /example
pathType:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this before paths field to remove confusion and what about the value of pathType:?
Example:

  hosts:
      - host: example1.com
        pathType: "ImplementationSpecific"
        paths:
            - /example

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeat all all places

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@prakarsh-dt prakarsh-dt merged commit d212da1 into devtron-labs:main Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants