Skip to content

Conversation

@Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Dec 17, 2025

Description

Fixes #

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


SATYAsasini and others added 9 commits December 12, 2025 17:02
…o user_deployment_request table (#6888)

Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
…sion for externalSecrets (#6892)

* Added new chart version 4-22-0 for deployment

* added new chart version 5-2-0 for statefulset

* Added sql for latest chart 4.22.0

* Added sql for latest statefulset chart 5.2.0

* Update 34704403_deployment-chart-ref_4-22-0.up.sql

* Update 34704404_statefulset_5_2_0.up.sql

* Update 34704404_statefulset_5_2_0.down.sql
* added rollout-chart-5-1-1

* added  name = 'Rollout Deployment'

* added reference-chart_5-1-1

* Update 34604602_reference-5-1-1.down.sql

* switched the chart version from 5.1.1 to 5.2.0

* took changes of deployement-4-22

* added migration

* Delete scripts/sql/34604602_reference-5-2-0.up.sql

* Delete scripts/sql/34604602_reference-5-2-0.down.sql
misc: update UserDeploymentRequestWithAdditionalFields struct to include tableName for PostgreSQL compatibility
@gitguardian
Copy link

gitguardian bot commented Dec 17, 2025

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9257608 Triggered Base64 AWS keys f733a1d scripts/devtron-reference-helm-charts/deployment-chart_4-22-0/test-values.json View secret
2763127 Triggered Generic High Entropy Secret 880110d scripts/devtron-reference-helm-charts/reference-chart_5-2-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret f733a1d scripts/devtron-reference-helm-charts/statefulset-chart_5-2-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bito-code-review
Copy link

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at shivam@devtron.ai.

@sonarqubecloud
Copy link

@Ash-exp Ash-exp merged commit 4b8eb26 into release-candidate-v0.44.0 Dec 17, 2025
7 checks passed
@Ash-exp Ash-exp deleted the chore/main-sync-17-dec branch December 17, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants