fix(clippy): satisfy Rust 1.95 unnecessary_sort_by + explicit_counter_loop#29
Merged
devwhodevs merged 1 commit intomainfrom Apr 21, 2026
Merged
fix(clippy): satisfy Rust 1.95 unnecessary_sort_by + explicit_counter_loop#29devwhodevs merged 1 commit intomainfrom
devwhodevs merged 1 commit intomainfrom
Conversation
…_loop Rust 1.95 promoted two clippy lints to deny-by-default in CI's -D warnings build. Replace sort_by with sort_by_key(|b| Reverse(...)) and derive vector IDs from the enumerate() index instead of a manual counter variable.
5 tasks
devwhodevs
added a commit
that referenced
this pull request
Apr 21, 2026
Patch release bundling three post-v1.6.0 fixes: - UTF-8 panic in temporal search (#24, thanks @majkelooo) - Rust 1.95 clippy CI breakage (#29) - rmcp 1.4 -> 1.5 for MCP protocol 2025-11-25, unblocks Claude Desktop Cowork / Code-in-Desktop tool surfacing (#20, #30)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy::unnecessary_sort_byandclippy::explicit_counter_loopto deny-by-default via-D warnings, breaking CI on PR fix(temporal): prevent panic on multi-byte UTF-8 queries #24 (macOS+Ubuntucheckjobs).sort_by(|a, b| b.x.cmp(&a.x))withsort_by_key(|b| Reverse(b.x))inidentity.rs(2x) andlinks.rs(2x).next_vid += 1pattern inindexer.rs,writer.rs(3x), andllm.rs— derive the vector id / sequence position from theenumerate()index instead.Once merged, PR #24 should pass CI on re-run (merge commit rebased onto fixed base).
Test plan
cargo clippy -- -D warningsclean on rustc 1.95.0cargo fmt --checkcleancargo test --lib— 458 passed, 0 failed