Skip to content

spack application added#263

Merged
sandipanpanda merged 1 commit intomainfrom
fix-interface
Jan 28, 2026
Merged

spack application added#263
sandipanpanda merged 1 commit intomainfrom
fix-interface

Conversation

@Rupam-It
Copy link
Contributor

@Rupam-It Rupam-It commented Jan 28, 2026

spark application add

📚 Description of Changes

Add in the interface about spark application !

Summary by CodeRabbit

  • New Features
    • Added support for managing Spark Applications and Scheduled Spark Applications as new resource types.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Added two new ResourceType enum values (SparkApplication and ScheduledSparkApplication) to the resource type collection system, with corresponding mappings in String() and ProtoType() methods to support protobuf conversion and string representation.

Changes

Cohort / File(s) Summary
ResourceType Enum Extension
internal/collector/interface.go
Added SparkApplication and ScheduledSparkApplication enum values; extended String() and ProtoType() methods with mappings for new resource types to "spark_application", "scheduled_spark_application" and corresponding protobuf enum constants

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • dray92

Poem

🐰 Spark applications now shine so bright,
Two new types added to our collector's sight,
SparkApplication and ScheduledSparkApplication too,
Protobuf mappings making dreams come true! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'spack application added' appears to be a typo for 'spark application added' based on the PR description and actual changes which add SparkApplication and ScheduledSparkApplication enum values. Correct the title to 'spark application added' or 'Add Spark application resource types' to accurately reflect the changes being introduced.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sandipanpanda sandipanpanda merged commit 5e317a2 into main Jan 28, 2026
26 checks passed
@sandipanpanda sandipanpanda deleted the fix-interface branch January 28, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants