Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

fix: resolve CLI lint workflow failure#15

Merged
devzucca merged 1 commit intomainfrom
dev
Mar 19, 2026
Merged

fix: resolve CLI lint workflow failure#15
devzucca merged 1 commit intomainfrom
dev

Conversation

@devzucca
Copy link
Copy Markdown
Owner

What this fixes

  • replaces invalid golangci-lint configuration in cli/.golangci.yaml with a valid minimal profile
  • fixes errcheck issue in telemetry HTTP client by handling response body close

Why

PR #14 had failing \Lint\ checks in workflow \AppLogger CLI - Build & Test\ due to config parse error:

  • \linters-settings.Tagliatelle.Case expected a map, got string\

Validation

  • golangci-lint v1.64.8 run locally: PASS
  • go test ./... in cli: PASS
  • pre-push hook in this repo: PASS

Copilot AI review requested due to automatic review settings March 19, 2026 15:56
@devzucca devzucca merged commit 02b13cb into main Mar 19, 2026
13 of 15 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the CLI lint workflow by replacing a broken golangci-lint configuration with a valid minimal config, and resolves an errcheck finding in the telemetry HTTP client by explicitly ignoring the Close() error.

Changes:

  • Simplify cli/.golangci.yaml to a minimal, valid golangci-lint configuration (avoids the prior config parse error).
  • Update telemetry HTTP response handling to satisfy errcheck by not discarding the Body.Close() return value.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cli/internal/cli/telemetry_client.go Wraps httpResp.Body.Close() in a defer func to explicitly ignore the error (satisfies errcheck).
cli/.golangci.yaml Replaces invalid/overly large linter config with a valid minimal enabled-linters set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants