This repository was archived by the owner on Nov 27, 2025. It is now read-only.
feat: add chat functions support #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| z.literal('gpt-3.5-turbo-0301'), | ||
| z.literal('gpt-3.5-turbo-16k'), | ||
| z.string(), | ||
| ]); |
Collaborator
There was a problem hiding this comment.
We can replace this with z.string(). The string part of the union makes the rest useless from a Zod perspective. I did it for autocompletion, but it doesn't actually work.
| /** The name of the function to call. */ | ||
| name: z.string(), | ||
| /** The arguments to call the function with, as generated by the model in JSON format. Note that the model does not always generate valid JSON, and may hallucinate parameters not defined by your function schema. Validate the arguments in your code before calling your function. */ | ||
| arguments: z.string(), |
Collaborator
There was a problem hiding this comment.
The node library types has name and arguments values as optional and the API reference docs don't specify 🤔
Contributor
Author
There was a problem hiding this comment.
Hmmm I'm not sure; I guess we should make them optional to guarantee that zod doesn't complain?
|
Maybe we can use https://zod.dev/?id=passthrough to allow unrecognized keys? This allows adopting new parameters faster for users. |
1 task
rileytomasek
added a commit
that referenced
this pull request
Jun 14, 2023
Using [`passthrough()`](https://zod.dev/?id=passthrough) will allow users to pass params that we haven't added to the Zod params schemas. Zod strips unknown keys from objects without this. Thanks: #26 (comment)
Collaborator
|
Moved to #27 |
rileytomasek
added a commit
that referenced
this pull request
Jun 15, 2023
* feat: add chat functions support * fix: add exports * fix: ChatMessage.content can now be null * Improve ChatMessage schemas/types Stricter support for narrowing/inference by using a union of the many variants of ChatMessage. * Add passthrough to all Zod parsing of params Using [`passthrough()`](https://zod.dev/?id=passthrough) will allow users to pass params that we haven't added to the Zod params schemas. Zod strips unknown keys from objects without this. Thanks: #26 (comment) * Export new ChatMessage types and schemas These will likely be helpful when working with the ChatMessage data before making the request. * Improve usability of function types --------- Co-authored-by: Travis Fischer <fisch0920@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openai.com/blog/function-calling-and-other-api-updates