fix: prevent template dictionary memory leak in ds-atleastonce demo#42
Merged
dexcompiler merged 3 commits intodemo/ds-atleastonce-idempotency-fixesfrom Feb 16, 2026
Merged
Conversation
Add cleanup of _templates dictionary in HandleAck to match cleanup of other dictionaries and prevent unbounded growth in long simulations. Co-authored-by: dexcompiler <115876036+dexcompiler@users.noreply.github.com>
Extract "payments" and "inventory" strings to constants for better maintainability and consistency across template operations. Co-authored-by: dexcompiler <115876036+dexcompiler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bounded inbox dedupe and stabilize MessageId
fix: prevent template dictionary memory leak in ds-atleastonce demo
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review identified a memory leak: the
_templatesdictionary grew unboundedly because it was never cleaned up when orders completed, negating the bounded inbox fix.Changes
HandleAckwhen both acks received, matching cleanup of_acks,_attempts, and_correlationIdsdictionariesPaymentsNodeNameandInventoryNodeNameconstants to ensure cleanup logic stays synchronized with template creationWithout this fix, long simulations would still experience unbounded growth through template accumulation despite the bounded inbox.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.