handle id_token_hint for implicit login flow#1508
handle id_token_hint for implicit login flow#1508scotthew1 wants to merge 2 commits intodexidp:masterfrom
Conversation
There was a problem hiding this comment.
not sure that we actually care if we can verify the signature here... if the token's in a client session from days ago, dex might not not have the keys to verify it anymore. since this is just a 'hint' rather than any proof of authentication, it's probably better to just get the sub claim without caring about the signature. thoughts?
|
Thanks for looking into this! 🎉 I'll review this soon, sorry for keeping you waiting. |
4044188 to
daf745f
Compare
|
We're still interested in this feature, is there anything I can do to help? |
|
@Toxicable Sorry, dropped the ball on this. Could you review this? |
|
The code that's there looks like it does what's intended. |
Handle
id_token_hintas described in #990