Skip to content

handle id_token_hint for implicit login flow#1508

Open
scotthew1 wants to merge 2 commits intodexidp:masterfrom
scotthew1:id-token-hint
Open

handle id_token_hint for implicit login flow#1508
scotthew1 wants to merge 2 commits intodexidp:masterfrom
scotthew1:id-token-hint

Conversation

@scotthew1
Copy link
Copy Markdown
Contributor

Handle id_token_hint as described in #990

Comment thread server/oauth2.go Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure that we actually care if we can verify the signature here... if the token's in a client session from days ago, dex might not not have the keys to verify it anymore. since this is just a 'hint' rather than any proof of authentication, it's probably better to just get the sub claim without caring about the signature. thoughts?

@srenatus
Copy link
Copy Markdown
Contributor

srenatus commented Aug 6, 2019

Thanks for looking into this! 🎉 I'll review this soon, sorry for keeping you waiting.

@Toxicable
Copy link
Copy Markdown

We're still interested in this feature, is there anything I can do to help?

@srenatus
Copy link
Copy Markdown
Contributor

@Toxicable Sorry, dropped the ball on this. Could you review this?

@Toxicable
Copy link
Copy Markdown

The code that's there looks like it does what's intended.
However I cant comment on the actual process, I don't know what are other valid inputs values and how they're meant to be handled

@nabokihms nabokihms mentioned this pull request Feb 18, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants