session/player.go: Decouple debugShapeToProtocol from Session#1182
Merged
DaPigGuy merged 1 commit intodf-mc:masterfrom Feb 21, 2026
Merged
session/player.go: Decouple debugShapeToProtocol from Session#1182DaPigGuy merged 1 commit intodf-mc:masterfrom
DaPigGuy merged 1 commit intodf-mc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted
debugShapeToProtocolto a standalone function. This follows the same pattern asinstanceFromItem,stackToItem,protocolToSkin, and others, which are already standalone functions and serve a similar purpose of converting to a protocol representation.This is required to be able to use the function outside of the session package with linkname, which I wish to do.
The only issue with this change is that
s.dimensionID()had to be replaced since the function no longer has access to the session. If necessary,Session.dimensionIDcould be decoupled, also.