crossbow.go: Fix crossbow charging animation played even if the player has no suitable item to insert projectile into it#1272
Merged
Conversation
…r has no suitable item to insert suitable projectile into it
Dasciam
changed the title
HashimTheArab
approved these changes
Jun 9, 2026
RestartFU
approved these changes
Jun 9, 2026
ClexaGod
added a commit
to GearsMC/dragonfly
that referenced
this pull request
Jun 9, 2026
* item/crossbow.go: Always set critical flag to match vanilla (df-mc#1270) * item/crossbow.go: Fix crossbow charging animation played even if the player has no suitable item to insert projectile into it (df-mc#1272) * crossbow.go: Fix crossbow charging animation played even if the player has no suitable item to insert suitable projectile into it * crossbow.go: use blank identifier for unused "tx" variable --------- Co-authored-by: Dasciam <122279000+Dasciam@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
CanChargemethod intoReleasableinterfaceTests:
Before:
Video_2026-06-09_05-03-04.mp4
After:
Video_2026-06-09_05-00-55.mp4