Add system-driven dark mode#36
Merged
Merged
Conversation
The app honored the OS color scheme only for the status bar; every surface was hardcoded to a light palette, which looked broken under a dark system theme. Introduce a small theme layer (light/dark semantic tokens + a useTheme hook over useColorScheme) and route every screen's colors through it, so appearance follows the system setting with no in-app toggle. The map is the centerpiece: it now swaps the MapLibre style URL to OpenFreeMap's dark basemap and recolors pins/controls for contrast against it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/theme/: light/dark semantic color tokens (colors.ts) and auseTheme()hook overuseColorScheme()(useTheme.ts). Appearance follows the system setting only — no in-app toggle.makeStyles(theme)factories. Light mode keeps the original colors, so it's visually unchanged.MapScreenswaps the MapLibre style URL to OpenFreeMap's dark basemap (…/styles/dark) in dark mode, and recolors pins, the pin ring, and the recenter button for contrast against it.App.tsxsets React Navigation's container theme (DarkTheme/DefaultTheme) so transition gaps don't flash white, and themes the splash/status bar.Surfaces themed
MapScreen, SearchOverlay, ElementPreviewCard, ElementDetailScreen, ElementEditScreen, FilterChips, AccountMenu, Sheet, LoginScreen.
Verification
tsc --noEmit,biome check, andjest(5 tests) all pass.