Create project structure #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Nov 23, 2022
Comment on lines
+9
to
+12
| .macOS(.v10_15), | ||
| .iOS(.v13), | ||
| .tvOS(.v13), | ||
| .watchOS(.v6), |
Owner
Author
There was a problem hiding this comment.
We're only running CI on the latest supported versions right now. I don't want to support Xcode versions prior to 14.1.
dfed
commented
Nov 23, 2022
| } | ||
|
|
||
| enum Platform: String, CaseIterable, CustomStringConvertible { | ||
| case iOS_13 |
Owner
Author
There was a problem hiding this comment.
We aren't using these older versions in CI, but they can be useful for running tests on older simulator OS versions locally.
dfed
force-pushed
the
dfed--project-structure
branch
7 times, most recently
from
4bee545 to
6fdba61
Compare
dfed
force-pushed
the
dfed--project-structure
branch
from
6fdba61 to
b5b023f
Compare
dfed
commented
Nov 23, 2022
| run: ./Scripts/prepare-coverage-reports.sh | ||
| - name: Upload Coverage Reports | ||
| if: success() | ||
| uses: codecov/codecov-action@v3 |
Owner
Author
There was a problem hiding this comment.
I'm surprised we're not yet getting any code coverage posts just yet, but we also have nearly zero code in the repo. I may put in a pin in this and hope it gets fixed by adding code or running this code on main. I'll fix this if either of the prior do not work.
Owner
Author
|
YOLO-merging this scaffolding PR. Future PRs with real content will receive reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the project structure, setting up the: