-
-
Notifications
You must be signed in to change notification settings - Fork 14
queue task add name #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable addition once it's compiling.
I think it'd make sense to add this name parameter to the Task initializers below as well, so that each individual task (not just the top-level queue) can be named.
Co-authored-by: Dan Federman <dfed@me.com>
Co-authored-by: Dan Federman <dfed@me.com>
|
Good improvements. Not sure why CI is still failing. Might be Swift 6.0 vs 6.2? I'm on mobile today so not sure. Can look closer tomorrow if you're stuck. Let me know! |
|
It seems to be an issue with Xcode 16. My Xcode 26 here is working fine It might be due to an error in the method signature caused by adding a name in Xcode 16 |
|
Looks like the |
|
But Task init name has long supported it |
|
I see that the method exists on older operating systems. But I don't see the It seems like this initializer was backported? I'm struggling to come up with an alternative. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1301 1301
=========================================
Hits 1301 1301
🚀 New features to boost your workflow:
|
dfed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.