Skip to content

Fix main build: add missing egress endpoints to harden-runner#1213

Merged
spoorcc merged 2 commits into
mainfrom
claude/fix-main-build-cCB7E
May 18, 2026
Merged

Fix main build: add missing egress endpoints to harden-runner#1213
spoorcc merged 2 commits into
mainfrom
claude/fix-main-build-cCB7E

Conversation

@spoorcc
Copy link
Copy Markdown
Contributor

@spoorcc spoorcc commented May 16, 2026

Summary

  • Add release-assets.githubusercontent.com:443 to source-provenance.yml — needed by slsa_with_provenance to download the slsa-source-corroborator binary from GitHub releases
  • Add timestamp.githubapp.com:443 to source-provenance.yml, build.yml, and test.yml — needed by actions/attest and actions/attest-build-provenance when signing DSSE attestation wrappers
  • Add uploads.github.com:443 to the build-whl job in build.yml — needed for artifact upload

All three endpoints were blocked by the harden-runner egress policy, cascading into build and test failures on main.

Test plan

  • source-provenance workflow passes on main (both attest-source-governance and attest-source jobs)
  • build workflow passes (binary and wheel jobs complete attestation steps)
  • test workflow passes attestation step

https://claude.ai/code/session_01FzXNiF3f5iEnRPX3SWfd2A


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD pipeline security configurations across build, testing, and attestation workflows to improve overall system reliability and security posture during the release process.

Review Change Stack

claude added 2 commits May 16, 2026 22:51
…s policy

The slsa_with_provenance action downloads the slsa-source-corroborator
binary from GitHub releases, which redirects through
release-assets.githubusercontent.com. This endpoint was missing from
the harden-runner allowed list for the attest-source-governance job,
causing the egress block and failing the main build.

https://claude.ai/code/session_01FzXNiF3f5iEnRPX3SWfd2A
actions/attest and actions/attest-build-provenance call
timestamp.githubapp.com when signing DSSE attestation wrappers.
This endpoint was absent from source-provenance.yml, build.yml,
and test.yml, causing the egress block to refuse the connection.

https://claude.ai/code/session_01FzXNiF3f5iEnRPX3SWfd2A
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 39d3be89-80bc-48ec-af12-8f0ce243ef54

📥 Commits

Reviewing files that changed from the base of the PR and between 79444c8 and 23f8ebc.

📒 Files selected for processing (3)
  • .github/workflows/build.yml
  • .github/workflows/source-provenance.yml
  • .github/workflows/test.yml

Walkthrough

This PR expands the egress allowlist in GitHub Actions runner hardening across three workflows. The build.yml workflow permits timestamp verification for builds and wheel creation. The test.yml workflow permits timestamp access during testing. The source-provenance.yml workflow permits release asset uploads and timestamp verification during provenance attestation.

Changes

CI Workflow Egress Allowlist Updates

Layer / File(s) Summary
Build and wheel build hardening
.github/workflows/build.yml
Build and build-whl jobs add timestamp.githubapp.com:443 and uploads.github.com:443 to the allowed-endpoints list for runner hardening.
Test job hardening
.github/workflows/test.yml
Test job adds timestamp.githubapp.com:443 to the allowed-endpoints list for runner hardening.
Source provenance attestation hardening
.github/workflows/source-provenance.yml
Attestation jobs add timestamp.githubapp.com:443, uploads.github.com:443, and release-assets.githubusercontent.com:443 to their allowed-endpoints lists for runner hardening.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • dfetch-org/dfetch#1199: Adds SLSA source-provenance and VSA attestation steps that require the expanded egress allowlist for timestamp and asset verification.
  • dfetch-org/dfetch#1212: Updates source-provenance.yml allowlist in the attest-source-governance job with related GitHub domain changes.
  • dfetch-org/dfetch#1190: Previously modified step-security/harden-runner allowed-endpoints in build.yml and other workflows.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the primary change: adding missing egress endpoints to harden-runner configurations across multiple workflows to fix build failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-main-build-cCB7E

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@spoorcc
Copy link
Copy Markdown
Contributor Author

spoorcc commented May 18, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@spoorcc spoorcc merged commit 0a1e9cc into main May 18, 2026
53 of 58 checks passed
@spoorcc spoorcc deleted the claude/fix-main-build-cCB7E branch May 18, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants