Fix main build: add missing egress endpoints to harden-runner#1213
Conversation
…s policy The slsa_with_provenance action downloads the slsa-source-corroborator binary from GitHub releases, which redirects through release-assets.githubusercontent.com. This endpoint was missing from the harden-runner allowed list for the attest-source-governance job, causing the egress block and failing the main build. https://claude.ai/code/session_01FzXNiF3f5iEnRPX3SWfd2A
actions/attest and actions/attest-build-provenance call timestamp.githubapp.com when signing DSSE attestation wrappers. This endpoint was absent from source-provenance.yml, build.yml, and test.yml, causing the egress block to refuse the connection. https://claude.ai/code/session_01FzXNiF3f5iEnRPX3SWfd2A
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR expands the egress allowlist in GitHub Actions runner hardening across three workflows. The ChangesCI Workflow Egress Allowlist Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
release-assets.githubusercontent.com:443tosource-provenance.yml— needed byslsa_with_provenanceto download theslsa-source-corroboratorbinary from GitHub releasestimestamp.githubapp.com:443tosource-provenance.yml,build.yml, andtest.yml— needed byactions/attestandactions/attest-build-provenancewhen signing DSSE attestation wrappersuploads.github.com:443to thebuild-whljob inbuild.yml— needed for artifact uploadAll three endpoints were blocked by the harden-runner egress policy, cascading into build and test failures on main.
Test plan
source-provenanceworkflow passes on main (bothattest-source-governanceandattest-sourcejobs)buildworkflow passes (binary and wheel jobs complete attestation steps)testworkflow passes attestation stephttps://claude.ai/code/session_01FzXNiF3f5iEnRPX3SWfd2A
Generated by Claude Code
Summary by CodeRabbit