Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## 2026-03-18

### Candid 0.10.26

* Bug fixes:
+ Fix decoding failure when a trailing argument is a primitive vector

## 2026-03-16

### Candid 0.10.25
Expand Down
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/bench/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/candid/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "candid"
# sync with the version in `candid_derive/Cargo.toml`
version = "0.10.25"
version = "0.10.26"
edition = "2021"
rust-version.workspace = true
authors = ["DFINITY Team"]
Expand All @@ -16,7 +16,7 @@ keywords = ["internet-computer", "idl", "candid", "dfinity"]
include = ["src", "Cargo.toml", "LICENSE", "README.md"]

[dependencies]
candid_derive = { path = "../candid_derive", version = "=0.10.25" }
candid_derive = { path = "../candid_derive", version = "=0.10.26" }
ic_principal = { path = "../ic_principal", version = "0.1.0" }
binread = { version = "2.2", features = ["debug_template"] }
byteorder = "1.5.0"
Expand Down
10 changes: 4 additions & 6 deletions rust/candid/src/de.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1241,14 +1241,12 @@ impl<'de> de::SeqAccess<'de> for Compound<'_, 'de> {
return Ok(None);
}
*len -= 1;
if exact_primitive.is_some() {
seed.deserialize(&mut *self.de).map(Some)
} else {
self.de.expect_type = expect.clone();
self.de.wire_type = wire.clone();
if exact_primitive.is_none() {
self.de.add_cost(3)?;
self.de.expect_type = expect.clone();
self.de.wire_type = wire.clone();
seed.deserialize(&mut *self.de).map(Some)
}
seed.deserialize(&mut *self.de).map(Some)
}
Style::Struct {
ref expect,
Expand Down
9 changes: 9 additions & 0 deletions rust/candid/tests/compatibility_vectors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,12 @@ fn bulk_encode_primitive_vectors_round_trip() {
let empty: Vec<i32> = vec![];
assert_eq!(Decode!(&Encode!(&empty).unwrap(), Vec<i32>).unwrap(), empty);
}

#[test]
fn primitive_vector_is_extra_args() {
let extra = vec![1i16, 2, 3];
let bytes = Encode!(&123u8, &extra).unwrap();

let decoded_values = Decode!(&bytes, u8).unwrap();
assert_eq!(decoded_values, 123);
}
2 changes: 1 addition & 1 deletion rust/candid_derive/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "candid_derive"
# sync with the version in `candid/Cargo.toml`
version = "0.10.25"
version = "0.10.26"
edition = "2021"
rust-version.workspace = true
authors = ["DFINITY Team"]
Expand Down
Loading