chore: remove stale TODO about charging cycles to caller#88
Merged
Conversation
The cycles are already charged in `update_balance` via `check_caller_available_cycles` and `charge_caller_cycles`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an outdated TODO comment in the transaction fetching path now that cycle charging behavior is already implemented elsewhere (per PR description).
Changes:
- Deleted stale
TODO DEFI-2643comment intry_get_transaction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maciejdfinity
approved these changes
Mar 30, 2026
gregorydemay
added a commit
that referenced
this pull request
May 22, 2026
## Summary Replace the bespoke `taiki-e/install-action` step (for `cargo-sort`) and the `cargo install canbench` step with a single `jdx/mise-action` step driven by a new `mise.toml` pinning Rust 1.93.0, cargo-sort 2.0.1, and canbench 0.4.1. Local development uses the same versions via `mise install`, so contributors and CI no longer diverge. Follows the pattern used in [`dfinity/internet-intelligence`](https://github.com/dfinity/internet-intelligence) and matches the migration already applied to `dfinity/crosschain-wallet` (#88) and `dfinity/evm-rpc-canister` (#589). Addresses [DEFI-2821](https://dfinity.atlassian.net/browse/DEFI-2821). [DEFI-2821]: https://dfinity.atlassian.net/browse/DEFI-2821?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO DEFI-2643comment intry_get_transaction— cycles are already charged to the caller inupdate_balanceviacheck_caller_available_cyclesandcharge_caller_cycles.🤖 Generated with Claude Code