fix(links): add specific anchors to all internal and icp-cli doc links#195
Merged
fix(links): add specific anchors to all internal and icp-cli doc links#195
Conversation
- Fixes 2 broken file links (binding-generation.md → candid.md#binding-generation) - Fixes 5 wrong anchors (candid-spec.md stale portal anchors, digital-asset-standards.md) - Adds section anchors to ~35 links that pointed to page tops (cycles-costs.md, inter-canister-calls.mdx, management-canister.md, lifecycle guides, etc.) - Upgrades all cli.internetcomputer.org links from bare root to versioned paths (/0.2/) with specific page paths and per-command anchors where applicable - Fixes issue #191: vetkd_encrypted_key → vetkd_derive_key, ic_ → ic- prefix typos in management-canister.md, #canister-ids → chain-key-canister-ids.md, #requesting-a-credential → #implementing-a-relying-party, XDR → glossary.md#xdr - Adds CLAUDE.md rules requiring specific anchors and versioned CLI doc paths so future agents don't reintroduce generic root links
ggreif
approved these changes
May 5, 2026
ggreif
left a comment
ggreif
left a comment
There was a problem hiding this comment.
The link/anchor fixes look reasonable. I didn't thoroughly analyse the skill changes. Potential bugs therein should become next generation time (and be nailed down in short order).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive anchor link audit across all 159 docs pages. Fixes broken anchors from issue #191, upgrades generic CLI doc links to versioned paths with per-command anchors, and adds missing section anchors throughout.
Broken anchors fixed (issue #191):
ic-interface-spec/canister-interface.md:#ic-vetkd_encrypted_key(method renamed) →./management-canister.md#ic-vetkd_derive_keyic-interface-spec/management-canister.md: 3×#ic_upload_canister_snapshot_metadata(_typo) →#ic-upload_canister_snapshot_metadataguides/digital-assets/chain-key-tokens.mdx:#canister-ids(section doesn't exist) →../../references/chain-key-canister-ids.mdguides/authentication/verifiable-credentials.md:#requesting-a-credential→#implementing-a-relying-partyreferences/candid-spec.md: 4 stale portal anchors →#the-did-fileand#safe-interface-upgradesreferences/glossary.md: all same-page anchors verified correct;references/cycles-costs.mdwas linking toglossary.mdwithout#xdr— fixedgetting-started/project-structure.mdx: 2 links to non-existentbinding-generation.md→candid.md#binding-generationCLI doc links (cli.internetcomputer.org):
/0.2/)reference/configuration,guides/creating-recipes,guides/canister-snapshots,guides/managing-environments,guides/containerized-networks,guides/installation#icp-canister-logs,#icp-canister-settings-update,#icp-cycles.sources/icp-cli/docs/Missing section anchors added (~35 links across 15 files):
Security guides, backend guides, canister management, concepts — links that pointed to page tops now point to the specific section.
CLAUDE.md rules added:
Two new bullets in the "Never" section requiring specific anchors on both internal links and
cli.internetcomputer.orglinks, with instructions on how to verify using.sources/icp-cli/docs/.Sync recommendation
hand-written— no upstream source changes, pure link quality fixes.