fix(security): remove outdated refs, broken links, and deprecated SDK usage#236
Merged
Merged
Conversation
- overview.md: update ANSSI Rust guide links to restructured URL paths - data-storage.md: remove abandoned ic-stable-memory library, rephrase intro; update encrypted-notes-dapp link to vetkeys example path - decentralization.md: remove LaunchTrail reference (abandoned 2022); remove basic_dao example link (path no longer exists on master) - canister-upgrades.md: update set_timer_interval links from ic-cdk to ic-cdk-timers crate where the function now lives
Update the client-side certificate verification example in
data-integrity-and-authenticity.md to use the current @icp-sdk/core/*
packages instead of the deprecated @dfinity/* packages.
- Replace @dfinity/agent, @dfinity/candid, @dfinity/principal with
@icp-sdk/core/agent, @icp-sdk/core/candid, @icp-sdk/core/principal
- Remove isomorphic-fetch (native fetch is used)
- HttpAgent: new HttpAgent() -> HttpAgent.create()
- Certificate: constructor + verify() -> Certificate.create() with
principal: { canisterId } (auto-verifies, throws on failure)
- cert.lookup() -> cert.lookup_path()
- Drop .buffer coercions: Candid already returns Uint8Array
- Fix pre-existing bug: start().await -> await start()
marc0olo
added a commit
that referenced
this pull request
May 12, 2026
… usage (#236) ## Summary - **overview.md**: Update 3 ANSSI Rust guide links to the restructured URL paths (`introduction.html`, `unsafe/generalities.html`, `integer.html#chapter-integer`, `libraries.html#cargo-audit`) - **data-storage.md**: Remove abandoned `seniorjoinu/ic-stable-memory` library (unmaintained since May 2023) and its caution block; rephrase intro to single remaining library; update encrypted notes example link from defunct `motoko/encrypted-notes-dapp` to `rust/vetkeys/encrypted_notes_dapp_vetkd` - **decentralization.md**: Remove LaunchTrail reference (`spinner-cash/launchtrail`, abandoned June 2022); remove `basic_dao` example link (path no longer exists on master) - **canister-upgrades.md**: Update both `set_timer_interval` links from `ic-cdk/0.6.9` to `ic-cdk-timers/1.0.0` (function moved crates) - **data-integrity-and-authenticity.md**: Migrate JavaScript client-side verification example from deprecated `@dfinity/agent`, `@dfinity/candid`, `@dfinity/principal` to `@icp-sdk/core/agent`, `@icp-sdk/core/candid`, `@icp-sdk/core/principal`; update `HttpAgent`, `Certificate`, and `lookup_path` APIs to v5; fix pre-existing `start().await` bug ## Sync recommendation `sync from dfinity/portal building-apps/security/*` — changes are fixes on top of the ported content; upstream source does not yet reflect the updated SDK or fixed links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
introduction.html,unsafe/generalities.html,integer.html#chapter-integer,libraries.html#cargo-audit)seniorjoinu/ic-stable-memorylibrary (unmaintained since May 2023) and its caution block; rephrase intro to single remaining library; update encrypted notes example link from defunctmotoko/encrypted-notes-dapptorust/vetkeys/encrypted_notes_dapp_vetkdspinner-cash/launchtrail, abandoned June 2022); removebasic_daoexample link (path no longer exists on master)set_timer_intervallinks fromic-cdk/0.6.9toic-cdk-timers/1.0.0(function moved crates)@dfinity/agent,@dfinity/candid,@dfinity/principalto@icp-sdk/core/agent,@icp-sdk/core/candid,@icp-sdk/core/principal; updateHttpAgent,Certificate, andlookup_pathAPIs to v5; fix pre-existingstart().awaitbugSync recommendation
sync from dfinity/portal building-apps/security/*— changes are fixes on top of the ported content; upstream source does not yet reflect the updated SDK or fixed links.