docs: Bitcoin integration guide#41
Merged
Merged
Conversation
Member
Author
Review: Bitcoin integration guideMust fix
Suggestions
Verified
|
Member
Author
|
No breaking changes. Please review before merging. |
49afa31 to
389f6ba
Compare
389f6ba to
836801a
Compare
Member
Author
|
Feedback addressed:
|
… links - Replace ic_cdk::bitcoin_canister imports with ic_cdk_bitcoin_canister (new 0.2 crate) - Uncomment and fix get_blockchain_info example using the new crate - Add bitcoin_send_transaction per-byte cycle costs (8M/20M per byte for testnet/mainnet) - Fix ckBTC skill URL to direct deep link - Add inline comment explaining amount+10 in Rust withdraw function - Update Upstream comment to include cdk-rs and portal cost reference pages
Member
Author
|
Feedback addressed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_blockchain_infoexample using the newic-cdk-bitcoin-canistercratebitcoin_send_transaction(8M/20M cycles per byte)Sync recommendation
Informed by
dfinity/portal—docs/build-on-btc/*,docs/references/bitcoin-how-it-works.mdx,docs/references/cycles-cost-formulas.mdx;dfinity/icskills—skills/ckbtc/SKILL.md;dfinity/icp-cli-templates—bitcoin-starter/;dfinity/cdk-rs—ic-cdk-bitcoin-canister 0.2