docs: getting-started quickstart page#5
Conversation
Review: getting-started/quickstart.md — Changes RequestedGood quickstart — clear flow, template variables verified. A few issues: 1. Inconsistent time claim
Pick one and make it consistent. 2. Unverifiable npm package namenpm install -g @icp-sdk/icp-cli @icp-sdk/ic-wasmThis package name isn't verifiable from the source material in ✓ Verified
|
Adds three new verification rules to the content authoring workflow: - Internal link verification: agents must confirm target files exist - External URL verification: agents must not guess/generalize crate URLs - Self-consistency check: frontmatter and body must not contradict Also expands linking rules table with ic-stable-structures and candid crate URLs, and adds a "never" rule against linking to non-existent pages. Motivated by review of PRs #2-#5 where agents linked to plausible but non-existent paths (reference/certified-variables.md, guides/backends/ stable-memory.md) and used wrong crate URLs (docs.rs/ic-cdk for ic-stable-structures).
Review: getting-started/quickstart.md (round 2)Must fix
Suggestions
Verified
|
Covers icp-cli installation, project scaffolding from hello-world template, local network setup, deployment, canister calls, and next steps. Includes Rust footnote, under-the-hood explanation of the two-canister architecture, and links to icp-cli docs for full reference. Source: icp-cli quickstart.md, tutorial.md, hello-world template
Link to reference/candid-spec.md instead of internetcomputer.org/docs/ which will be dead once the new docs site launches.
df39e1d to
fc3be12
Compare
|
Feedback addressed:
|
There was a problem hiding this comment.
Pull request overview
Replaces the Getting Started quickstart stub with a complete walkthrough for installing icp-cli, scaffolding a full-stack project, running a local network, deploying, and calling a canister, plus brief architecture context and next-step links.
Changes:
- Adds prerequisites and tool installation steps (
icp-cli,ic-wasm,ic-mops). - Documents a linear “create → start local network → deploy → call canister → stop network” flow (Motoko + React, with a Rust alternative note).
- Adds an “under the hood” section describing the backend + frontend canister model and links to follow-on pages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Per-canister config files are canister.yaml, not icp.yaml
|
Feedback addressed:
|
The hello-world template only supports frontend_type=react. For backend-only projects, use --subfolder rust or --subfolder motoko which are dedicated backend-only templates.
|
Feedback addressed:
|
- Fix factually incorrect ckETH deposit flow: remove false minter_address function claim and unique-per-principal address claim; describe the correct flow using the deposit function on the shared helper contract with ICP principal as call data, and the minter monitoring ReceivedEth events - Change chain-key cryptography link from external Learn Hub URL to internal page (docs/concepts/chain-key-cryptography.md) per CLAUDE.md linking rules - Add ckBTC Checker canister ID (oltsj-fqaaa-aaaar-qal5q-cai) to the canister table since the page already references the checker's public audit - Add created_at_time for dedup protection in withdrawal code (Motoko and Rust) with explanatory comment per icrc-ledger skill pitfall #5 - Update Upstream comment to reference .sources/ repos instead of external URL
Summary
rustandmotokosubfolder templatesSync recommendation
informed bydfinity/icp-cli — quickstart.md, tutorial.md