docs: system canisters reference#66
Conversation
df43459 to
47664c9
Compare
Review: System CanistersMust fix
Suggestions
Verified
|
- Replace invalid `icp deps pull`/`icp deps deploy` commands (no such subcommand in icp-cli) with correct `icp.yaml` network config using `ii: true` / `nns: true` flags and `icp network start -d` - Fix config filename: `icp.json` → `icp.yaml` (verified against icp-cli configuration reference) - Fix ICP index method name: `get_account_identifier_transactions` → `get_account_transactions` (verified in portal source) - Update Rust snippet from deprecated `ic_cdk::call()` (removed in cdk-rs 0.18.0) to current `Call::bounded_wait().with_arg().await? .candid()` API - Fix Motoko `canister:` import: raw canister IDs are not valid; replace with named alias form (`canister:icp_ledger_canister`) and actor syntax for hardcoded ID, with explanatory note - Update Internet Identity section to reference correct local dev method
|
<!-- feedback-addressed --> Feedback addressed: System Canisters (PR #66)All five "Must fix" items were applied. Four "Suggestions" were skipped with reasons below. Changes applied1. Invalid The 2. Config filename corrected: Verified against 3. ICP index method name corrected: Verified against 4. Rust snippet updated to current The old 5. Motoko
6. Internet Identity section updated Removed the reference to the non-existent Items skippedSuggestion: Candid interfaces for all canisters — Skipped. Adding complete Candid interface snippets for all system canisters is a scope expansion beyond what Suggestion: CMC minting — lead with Suggestion: NNS UI mentioned in NNS section intro paragraph — Skipped. The NNS UI has its own subsection and appears in the summary table. The intro paragraph describes the NNS governance function where the UI frontend is not architecturally relevant to include. Suggestion: Remove redundant opening sentence — Skipped. The sentence confirms the page scope for users who land from search. This is a style preference with no factual bearing; removing it does not materially improve clarity. |
Summary
icp deps pullfor local developmentSync recommendation
informed by
dfinity/portal—docs/references/system-canisters/index.mdx;docs/references/system-canisters/xrc.mdx