feat: self update#41
Merged
1 commit merged intoJan 19, 2024
Merged
Conversation
viviveevee
approved these changes
Jan 19, 2024
| #[error(transparent)] | ||
| DownloadLatestBinaryError(#[from] DownloadLatestBinaryError), | ||
|
|
||
| #[error("failed to execute {command:#?}")] |
There was a problem hiding this comment.
Suggested change
| #[error("failed to execute {command:#?}")] | |
| #[error("failed to execute {command:#?}. Error: {source}")] |
I feel like having the error available would make support on e.g. the forum much easier
Author
There was a problem hiding this comment.
This happens automatically, because the variable is called source. See https://github.com/dfinity/dfxvm/blob/main/src/log.rs#L30
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the
dfxvm self updatecommand.Fixes https://dfinity.atlassian.net/browse/SDK-1272
How Has This Been Tested?
Added tests
Tested locally by:
dfxvm self updatedfxvm-init --self-replace, since the older releases obviously don't support this functionalitydfxvm-init-self-update --self-replacein the bin directoryChecklist: