Skip to content

chore: changing default behavior if cursor is not present#466

Merged
NikolaMilosa merged 1 commit intomainfrom
nm-changing-default-behavior
Jun 7, 2024
Merged

chore: changing default behavior if cursor is not present#466
NikolaMilosa merged 1 commit intomainfrom
nm-changing-default-behavior

Conversation

@NikolaMilosa
Copy link
Copy Markdown
Contributor

Previously, if the __CURSOR wasn't present we would start fetching only the newest logs. While convenient it we had some issues where we would lose logs or have to refetch from the start and this would help us achieve that more easily. When the new target is added we will start fetching logs from the start of their journal

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner June 7, 2024 11:58
Copy link
Copy Markdown
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikolaMilosa NikolaMilosa merged commit 1d39289 into main Jun 7, 2024
@NikolaMilosa NikolaMilosa deleted the nm-changing-default-behavior branch June 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants