Skip to content

chore(dre): Rename --simulate to --dry-run#504

Merged
sasa-tomic merged 1 commit intomainfrom
sat-rename-simulate
Jun 20, 2024
Merged

chore(dre): Rename --simulate to --dry-run#504
sasa-tomic merged 1 commit intomainfrom
sat-rename-simulate

Conversation

@sasa-tomic
Copy link
Copy Markdown
Member

  • this makes it more consistent with ic-admin
  • it's backwards compatible since the old arguments are still accepted

- this makes it more consistent with ic-admin
- it's backwards compatible since the old arguments are still accepted
@sasa-tomic sasa-tomic requested a review from a team as a code owner June 20, 2024 10:19
Copy link
Copy Markdown
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@sasa-tomic sasa-tomic merged commit 2eae860 into main Jun 20, 2024
@sasa-tomic sasa-tomic deleted the sat-rename-simulate branch June 20, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants