docs: fix links #1055
Merged
docs: fix links #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marc0olo
commented
Nov 22, 2024
marc0olo
commented
- wrong LICENSE file name/reference lead to a broken link in the portal URL check
- github issue link didn't make sense
7 tasks
Contributor
Member
Author
|
@altkdf thanks for pointing that out. mhh, can we somehow get the conflicts in the other branch fixed and get it merged as soon as possible? otherwise it would be great to just approve this now so that we are unblocked in terms of getting the docs updated in the portal. I do not think it is very urgent, so I am also fine just closing this PR here 😅 I didn't know about the sideeffects with the portal repo. so we should always be careful when linking between markdowns here in the examples repo |
altkdf
approved these changes
Nov 22, 2024
Contributor
altkdf
left a comment
altkdf
left a comment
There was a problem hiding this comment.
Then let's just approve this PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.