Skip to content

Conversation

@marc0olo
Copy link
Member

I recognized we introduced a link which doesn't work in this PR that got merged recently: #1073

@marc0olo marc0olo requested a review from a team as a code owner January 16, 2025 07:48
@letmejustputthishere
Copy link
Contributor

i think its better to point to a specific commit in case the file get's renamend or put into a different directory

@marc0olo
Copy link
Member Author

I think this is in general not very convenient at this point, but I see your point. IMO it is fine for the moment and we should rather consider to create a dedicated repository just for scripts to be (re-)used across different repos.

personally I prefer relying on master over some potentially very outdated commit. if the script needs to change for whatever reason, we ultimately have a similar issue.

@marc0olo marc0olo force-pushed the fix/download-latest-icrc1-ledger branch from 3cd2324 to e525d74 Compare January 16, 2025 15:30
@marc0olo
Copy link
Member Author

@letmejustputthishere I switched to a specific commit now. my concerns above remain though 😛

@marc0olo marc0olo force-pushed the fix/download-latest-icrc1-ledger branch from e525d74 to 1db9d49 Compare January 16, 2025 20:05
@marc0olo
Copy link
Member Author

@letmejustputthishere I think I only missed https://github.com/dfinity/examples/tree/master/rust/icp_transfer which I fixed now, too

@letmejustputthishere
Copy link
Contributor

thank you!

@letmejustputthishere letmejustputthishere merged commit 0f7ecd6 into master Jan 17, 2025
13 checks passed
@letmejustputthishere letmejustputthishere deleted the fix/download-latest-icrc1-ledger branch January 17, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants