chore(crypto): CRP-2664 remove mock canister from basic_bitcoin examples#1103
Merged
chore(crypto): CRP-2664 remove mock canister from basic_bitcoin examples#1103
basic_bitcoin examples#1103Conversation
altkdf
changed the title
basic_bitcoin examplesbasic_bitcoin examples
Contributor
Author
|
Duplicated the key name changes from #1102, which is not yet merged. |
letmejustputthishere
approved these changes
Feb 27, 2025
viviveevee
approved these changes
Feb 27, 2025
michael-weigelt
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dfxand Pocket IC now support BIP341 key tweaking, so there is no need for a mock canister in the local deployment anymore. It makes sense though to leave a comment about the existence of the chainkey testing canister to make people aware that this is a cheaper option for testing on mainnet.