Skip to content

chore: Update for Ninja Examples #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fxgst merged 14 commits into from
Mar 28, 2025
Merged

chore: Update for Ninja Examples #1118

fxgst merged 14 commits into from
Mar 28, 2025

Conversation

@fxgst
Copy link
Contributor

@fxgst fxgst commented Mar 27, 2025

  • add instructions how to add an ICP Ninja project
  • remove Motoko playground referernces
  • add open in ICP Ninja button
  • rename workflow to specifically mention Ninja, remove Makefile option to avoid confusion
  • update READMEs
  • move .devcontainer.json into .devcontainer folder

@fxgst fxgst requested a review from a team as a code owner March 27, 2025 12:28
georgi-dfinity
georgi-dfinity reviewed Mar 27, 2025
View reviewed changes
jessiemongeon1
jessiemongeon1 approved these changes Mar 27, 2025
View reviewed changes
@fxgst fxgst requested a review from a team as a code owner March 27, 2025 15:00
fxgst and others added 10 commits March 28, 2025 09:54
@fxgst @jessiemongeon1
Update motoko/backend_only/README.md
40e85ff 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update README.md
97630f1 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update NINJA_CONTRIBUTING.md
7209076 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update ADDING_AN_EXAMPLE.md
1012409 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update NINJA_CONTRIBUTING.md
c5dfa0c 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update NINJA_CONTRIBUTING.md
e13572e 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update NINJA_CONTRIBUTING.md
5f666a4 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update NINJA_CONTRIBUTING.md
10c579f 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update NINJA_CONTRIBUTING.md
26e83cf 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst @jessiemongeon1
Update NINJA_CONTRIBUTING.md
2422815 
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
@fxgst fxgst merged commit 3474707 into master Mar 28, 2025
25 checks passed
@fxgst fxgst deleted the elias/ninjaupdate branch March 28, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgi-dfinity georgi-dfinity georgi-dfinity left review comments

+1 more reviewer

@jessiemongeon1 jessiemongeon1 jessiemongeon1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fxgst @georgi-dfinity @jessiemongeon1