chore: prepare more examples for Ninja#1259
Merged
viviveevee merged 12 commits intomasterfrom Aug 27, 2025
Merged
Conversation
marc0olo
approved these changes
Aug 26, 2025
Member
marc0olo
left a comment
marc0olo
left a comment
There was a problem hiding this comment.
what's the reason for removing the Makefile in the classes example and the package-lock files?
I assume you removed the workflows because that would be a duplicate run as this is covered by the ninja-pr-checks, right?
Contributor
Author
|
The removed The package-lock files are not very useful because they get outdated all the time, and we don't run Yes, the removed workflows would just duplicate work |
alexandru-uta
approved these changes
Aug 27, 2025
Contributor
alexandru-uta
left a comment
alexandru-uta
left a comment
There was a problem hiding this comment.
Thanks! files owned by languages look good!
adamspofford-dfinity
approved these changes
Aug 27, 2025
berestovskyy
approved these changes
Aug 27, 2025
fxgst
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.