chore(motoko): migrate cert-var to mo:core 2.4.0#1340
Merged
Conversation
- Add mops.toml: moc 1.5.1, core 2.4.0, -W=M0236,M0237,M0223 - Update dfx.json packtool to "mops sources" - Replace mo:base imports with mo:core equivalents - Drop unused Debug import - Use x.toNat8() context dot instead of Nat8.fromNat(Nat32.toNat(x)), dropping Nat8 import - Fix M0194: blobOfNat32 was using captured `value` instead of parameter `n`
raymondk
reviewed
Apr 21, 2026
| func byte(x : Nat32) : Nat8 { | ||
| Nat8.fromNat(Nat32.toNat(x)); | ||
| }; | ||
| func byte(x : Nat32) : Nat8 = x.toNat8(); |
Contributor
There was a problem hiding this comment.
If this is really necessary maybe it should be in the certified data. It doesn't make sense that a user would have to implement it themselves.
raymondk
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mops.toml: moc 1.5.1, core 2.4.0,-W=M0236,M0237,M0223dfx.jsonpacktool tomops sourcesmo:baseimports withmo:coreequivalentsDebugimportx.toNat8()context dot instead ofNat8.fromNat(Nat32.toNat(x)), dropping theNat8importblobOfNat32was using captured actor fieldvalueinstead of its parametern(functionally equivalent since it's always called withvalue, but causes an unused-parameter warning)