fix(stakes): remove 1 ICP minimum for neuron top-up#347
Merged
Conversation
1a387e3 to
e8561c6
Compare
📊 Build Bundle StatsThe latest build generated the following assets: |
There was a problem hiding this comment.
Pull request overview
This PR updates the neuron top-up (increase stake) flow to remove the frontend’s 1 ICP minimum and instead only require a positive amount, aligning the validation/error message with the Send ICP flow.
Changes:
- Removed the 1 ICP minimum validation from the neuron top-up view and replaced it with a “greater than zero” check.
- Updated the English i18n error message for low amount to “Enter an amount greater than zero.”
- Adjusted the e2e test case for the top-up validation flow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/governance-app-frontend/src/features/stakes/components/neuronDetail/NeuronDetailIncreaseStakeView.tsx | Replaces min-amount validation with <= 0 validation for top-ups. |
| src/governance-app-frontend/src/i18n/en/modals/neuronDetail.json | Updates the low-amount error message text for neuron top-up. |
| src/governance-app-frontend/tests/e2e/neuron-detail-modal.spec.ts | Updates e2e validation scenario inputs for the top-up flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...e-app-frontend/src/features/stakes/components/neuronDetail/NeuronDetailIncreaseStakeView.tsx
Show resolved
Hide resolved
0xFFrancesco
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The top-up neuron flow previously enforced a minimum of 1 ICP on the frontend, but there is no such limit at the protocol level. Any positive amount should be valid for topping up an existing neuron.
Changes