Skip to content

style: align better with the response verification monorepo#3

Merged
nathanosdev merged 1 commit intomainfrom
nathan/align-with-response-verification-repo
Sep 20, 2023
Merged

style: align better with the response verification monorepo#3
nathanosdev merged 1 commit intomainfrom
nathan/align-with-response-verification-repo

Conversation

@nathanosdev
Copy link
Copy Markdown
Contributor

@nathanosdev nathanosdev commented Sep 18, 2023

Some minor changes to align this repo better with the response verification repo, namely:

  • Using Vite to build/test
  • Forcing PNPM and Node versions
  • NVM support
  • Prettier/typescript configs
  • Docs format
  • Folder naming conventions

Comment thread packages/http-canister-client/src/http-interface/http-interface.did
@nathanosdev nathanosdev marked this pull request as ready for review September 18, 2023 22:13
@nathanosdev nathanosdev requested a review from a team as a code owner September 18, 2023 22:13
Copy link
Copy Markdown
Member

@keplervital keplervital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanosdev nathanosdev merged commit 702a80f into main Sep 20, 2023
@nathanosdev nathanosdev deleted the nathan/align-with-response-verification-repo branch September 20, 2023 08:12
mraszyk pushed a commit to mraszyk/http-gateway that referenced this pull request Jul 29, 2024
…ry-library

feat(BOUN-1156): Integration of Discovery Library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants