Skip to content

feat(ic-http-gateway): propagate http error#33

Merged
nathanosdev merged 1 commit intomainfrom
nathan/improve-http-error
Feb 10, 2025
Merged

feat(ic-http-gateway): propagate http error#33
nathanosdev merged 1 commit intomainfrom
nathan/improve-http-error

Conversation

@nathanosdev
Copy link
Copy Markdown
Contributor

No description provided.

@nathanosdev nathanosdev marked this pull request as ready for review December 17, 2024 11:55
@nathanosdev nathanosdev requested a review from a team as a code owner December 17, 2024 11:55
@nathanosdev nathanosdev force-pushed the nathan/improve-http-error branch 3 times, most recently from 2a7c94c to f84e3d4 Compare February 10, 2025 15:37
Comment thread packages/ic-http-gateway/src/error.rs
Comment thread packages/ic-http-gateway/src/protocol/handler.rs
@nathanosdev nathanosdev force-pushed the nathan/improve-http-error branch from f84e3d4 to 1f89a0b Compare February 10, 2025 15:40
@nathanosdev nathanosdev force-pushed the nathan/improve-http-error branch from 1f89a0b to ba6cb08 Compare February 10, 2025 16:30
Copy link
Copy Markdown
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nathanosdev nathanosdev merged commit aa5e33b into main Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants